Skip to content

Bug: Watch configuration can panic on an empty context list - #614

Closed
aniket866 wants to merge 2 commits into
microcks:masterfrom
aniket866:fix/watch-config-empty-context
Closed

aniket866 wants to merge 2 commits into
microcks:masterfrom
aniket866:fix/watch-config-empty-context

Conversation

@aniket866

Copy link
Copy Markdown
Contributor

Closes #613

check issue 613 for context

Summary

  • Prevent panic when watch entry Context is nil or empty.
  • Return and propagate a validation error.
  • Add regression coverage.

Testing

image

Ai disclosure: chatgpt is used to review related files and do changes.

Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
@aniket866 aniket866 changed the title fix: validate empty watch contexts Bug: Watch configuration can panic on an empty context list Oct 31, 2026
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
@aryarathoree

Copy link
Copy Markdown
Contributor

Hey @aniket866! Following up on @Caesarsage’s note in #610 to coordinate on this.

PR #614 already handles the empty-context validation and signature change, while #610 covers the context wipeout and deduplication issues.

I have the merging/deduplication logic and tests ready. Would you prefer that I open a PR against your branch (aniket866:fix/watch-config-empty-context) so we can combine everything into #614, or should I put together a unified PR and include you as a co-author?

Happy to go with whichever approach works best for you!

@Caesarsage

Copy link
Copy Markdown
Collaborator

Thanks @aniket866! #610 was reported first and @aryarathoree's PR fixes all of it, including the empty-context case, so I'm closing this one in favour of it. You've got #547 and #607 close to ready; let's land those next.

@Caesarsage Caesarsage closed this Nov 4, 2026

This branch was previously deployed

1 inactive deployment
Build — 573ae7e9 Deployed Oct 31, 2026 by aniket866 via build-verify-package #859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Watch configuration can panic on an empty context list

3 participants